feats

src/main/java/com/shigongli/controller/TaHouseController.java

@@ -126,14 +126,7 @@ public class TaHouseController extends BaseController {
         }
 
         if (!StringUtils.isEmpty(taHouse.getShopId())) {
-            boolean found = false;
-            for (TaShopKeeper keeper: shopKeeperList) {
-                if (taHouse.getShopId().equals(keeper.getShopId())) {
-                    found = true;
-                }
-            }
-
-            if (!found) {
+            if (!isContaints(shopKeeperList, taHouse.getShopId())) {
                 return ResponseBean.error("您无权新增房源, 或房源所属民宿出错", ResponseBean.ERROR_UNAVAILABLE);
             }
         } else {
@@ -182,8 +175,7 @@ public class TaHouseController extends BaseController {
             return ResponseBean.error("店主数据异常", ResponseBean.ERROR_UNAVAILABLE);
         }
 
-        TaShopKeeper taShopKeeper = shopKeeperList.get(0);
-        if (!taShopKeeper.getShopId().equals(taHouse.getShopId())) {
+        if (!isContaints(shopKeeperList, taHouse.getShopId())) {
             return ResponseBean.error("您无权进行当前操作", ResponseBean.ERROR_UNAVAILABLE);
         }
 
@@ -275,4 +267,16 @@ public class TaHouseController extends BaseController {
         return city;
     }
 
+    private boolean isContaints(List<TaShopKeeper> shopKeepers, String shopId) {
+        if (null == shopKeepers) return false;
+
+        for (TaShopKeeper shopKeeper : shopKeepers) {
+            if (shopKeeper.getShopId().equals(shopId)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
 }